-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ERC-1271 support and testing a partner wallet app. #609
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
Added integration tests for signature verification, owner revocation, time travel logic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good
Adding here that running our test suite locally breaks; added
you need to install foundry with:
then run the tests again, and they should pass. |
@tuddman Thanks! I wonder can we easily add |
Adds ERC-1271 support and tests for open sourced coinbase smart wallet.
closes #608